vue-simple-suggest should not mutate the array provided to the "list" property #590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
currently vue-simple-suggest mutates any array supplied to the "list" property when the "max-suggestions" property is used.
This breaks the One-Way Data Flow recommended by Vue and affects parent state by triggering any watcher on the
listOfSuggestions
list, etc...The reason for this property mutation is that the library internally uses the
splice()
function on the provided list, instead of using theslice()
function which returns an array copy.Thierry.