translating absolute message with domain is not supported exception

[Fixes #127]
Kdyby · May 16, 2017 · 00f555f · 00f555f
1 parent 044b093
commit 00f555f
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/Kdyby/Translation/Translator.php b/src/Kdyby/Translation/Translator.php
@@ -158,6 +158,14 @@ public function translate($message, $count = NULL, $parameters = [], $domain = N
 		}
 
 		if (Strings::startsWith($message, '//')) {
+			if ($domain !== NULL) {
+				throw new InvalidArgumentException(sprintf(
+					'Providing domain "%s" while also having the message "%s" absolute is not supported',
+					$domain,
+					$message
+				));
+			}
+
 			$message = Strings::substring($message, 2);
 		}
 

diff --git a/tests/KdybyTests/Translation/Translator.phpt b/tests/KdybyTests/Translation/Translator.phpt
@@ -158,6 +158,17 @@ class TranslatorTest extends TestCase
 		Assert::same("Ahoj světe", $translator->translate('//front.homepage.hello'));
 	}
 
+
+
+	public function testTranslatingAbsoluteMessageWithDomainIsNotSupported()
+	{
+		$translator = $this->createTranslator();
+
+		Assert::exception(function () use ($translator) {
+			$translator->translate('//homepage.hello', NULL, [], 'front');
+		}, 'Kdyby\Translation\InvalidArgumentException', 'Providing domain "front" while also having the message "//homepage.hello" absolute is not supported');
+	}
+
 }
 
 (new TranslatorTest())->run();