Testing PR for support nette 3.0 #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Barbarossa-42 need some help for finish this PR? |
|
@aleswita yes please :) |
|
@Barbarossa-42 can you add me as maintainer to your translation repository? |
added 10 commits
March 11, 2019 15:04
|
Hi, need a hand? I'd like to contribute to this repo, as I need Kdyby\Translation working with Nette v3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
working setup for #157 (translating and caching works for me)
Please merge to testing branch or new upcoming release (nette-3.0) after review and i will take a look for other dependencies and all test coverage.
What else need to be done
Kdyby/Strict-objects
This should be compatible with Nette\DI\CompilerExtension:
replace
public function __get(string $name)forpublic function &__get(string $name)etc
kdyby/console and kdyby/monolog
need update for nette 3.0 compatibility
Thanks for take a look.