Web import accounts #123
Open
Web import accounts #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto web-import-accounts
…nto web-import-accounts
…nto web-import-accounts
…nto web-import-accounts
…nto web-import-accounts
Jannyboy313
requested changes
Jun 24, 2021
There was a problem hiding this comment.
- Test csv bestanden moeten verwijderd worden
- 2x Gevonden
- Je krijgt geen error wanneer je een lege csv aanmaakt
- Csv bestand kan lege waardes bevatten (Geen validatie)??
- Er mist een pop up voor het verwijderen
- Als een csv niet wilt inladen krijg ik geen error
- Header zou niet zichtbaar moeten zijn (firstname,lastname ect)
"Aanmaken" Valt buiten de popup
De "role" is niet zichtbaar in de popup, wanneer ik een csv bestand maak?
| @@ -54,6 +54,10 @@ export class UserDao { | |||
| return this.dao.sendPostRequest('user/register', body); | |||
| } | |||
|
|
|||
| registerUsers(body: unknown[]) { | |||
There was a problem hiding this comment.
Verander die unknown naar een any of een daadwerkelijke type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.