Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nodejs to v20 #1037

Merged
merged 4 commits into from
Nov 19, 2023
Merged

Bump nodejs to v20 #1037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9861375
Bump nodejs engine to v20
Kesin11 Nov 19, 2023
ca8fb4e
Bump container nodejs to v20
Kesin11 Nov 19, 2023
4c198b0
docs: Change repository in sample config
Kesin11 Nov 19, 2023
152cd32
Enable source maps at 'npm run start'
Kesin11 Nov 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// README at: https://github.com/devcontainers/templates/tree/main/src/typescript-node
{
"name": "Node.js & TypeScript",
"image": "mcr.microsoft.com/devcontainers/typescript-node:18",
"image": "mcr.microsoft.com/devcontainers/typescript-node:20",
"features": {
"ghcr.io/devcontainers/features/docker-from-docker:1": {},
"ghcr.io/devcontainers/features/github-cli:1": {},
Expand Down
4 changes: 2 additions & 2 deletions Earthfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
VERSION 0.7

# TypeScript build
FROM node:18.18.2
FROM node:20.9.0
LABEL org.opencontainers.image.source=https://github.com/Kesin11/CIAnalyzer
LABEL [email protected]
WORKDIR /build
Expand Down Expand Up @@ -43,7 +43,7 @@ test:
SAVE ARTIFACT coverage AS LOCAL ./coverage

docker:
FROM node:18-alpine
FROM node:20-alpine
WORKDIR /ci_analyzer
# Resolve nodejs pid=1 problem
RUN apk add --no-cache tini
Expand Down
2 changes: 1 addition & 1 deletion ci_analyzer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ github:
- name: $CUSTOM_REPORT_NAME # It must be same bigquery.customReports[].name
paths:
- 'custom_report.json' # Path at inside of artifact.
- Kesin11/Firestore-simple # Can use abbr format if don't collect test report
- Kesin11/ts-junit2json # Can use abbr format if don't collect test report
exporter: &exporter # Can use yaml anchor
local:
outDir: ./output # default: output
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@
},
"homepage": "https://github.com/Kesin11/CIAnalyzer#readme",
"engines": {
"node": ">=18.18.2"
"node": ">=20.9.0"
},
"bin": {
"ci_analyzer": "dist/index.js"
},
"scripts": {
"start": "node dist/index.js",
"start": "node --enable-source-maps dist/index.js",
"clean": "rimraf dist",
"build": "tsc -b",
"build:clean": "npm run clean && npm run build",
Expand Down