feat: adjust mrt_dentsitystate according to the doc
#494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mr-pinzhang is attempting to deploy a commit to the Kevin Vandy OSS Team on Vercel. A member of the Team first needs to authorize it. |
mr-pinzhang
commented
Feb 20, 2025
| @@ -13,7 +13,9 @@ interface Props<TData extends MRT_RowData> | |||
| table: MRT_TableInstance<TData>; | |||
| } | |||
|
|
|||
| const next: Record<MRT_DensityState, MRT_DensityState> = { | |||
| type TogglableDensityState = Exclude<MRT_DensityState, 'lg' | 'sm'>; | |||
There was a problem hiding this comment.
I am trying not to touch the density toggle function here.
mr-pinzhang
commented
Feb 20, 2025
Comment on lines
+124
to
+130
| const defaultRowHeightByDensity: Record<MRT_DensityState, number> = { | ||
| lg: 61, | ||
| md: 53, | ||
| sm: 45, | ||
| xl: 69, | ||
| xs: 37, | ||
| }; |
There was a problem hiding this comment.
I find this pattern by myself, noticing the row height increase by 8 per each density. let me know if I'm doing it in a wrong way.
mr-pinzhang
commented
Feb 20, 2025
Comment on lines
+44
to
+50
| const defaultRowHeightByDensity: Record<MRT_DensityState, number> = { | ||
| lg: 62.7, | ||
| md: 54.7, | ||
| sm: 48.7, | ||
| xl: 70.7, | ||
| xs: 42.7, | ||
| }; |
There was a problem hiding this comment.
not sure how this number gets calculated. from xs to md, it's a number gap of 12. For md to xl, it's 16. so I put 6+ for sm, and 8+ for 'lg` here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey MRT developers, this PR is made to adjust the definition of
type MRT_DensityStateto what we have on docs.