Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR] Update Circle strings #2250

Merged
merged 2 commits into from
Feb 24, 2025
Merged

[SR] Update Circle strings #2250

merged 2 commits into from
Feb 24, 2025

Conversation

nishasy
Copy link
Contributor

@nishasy nishasy commented Feb 19, 2025

Summary:

We're doing a final pass on strings now at the end of the phase 1
interactive graph screen reader work.

  • Update the circle radius point’s label to “<Right/Left> radius endpoint at ."

Issue: https://khanacademy.atlassian.net/browse/LEMS-2782

Test plan:

yarn jest packages/perseus/src/widgets/interactive-graphs/graphs/circle.test.tsx

Storybook

We're doing a final pass on strings now at the end of the phase 1
interactive graph screen reader work.

- Update the circle radius point’s label to “<Right/Left> radius endpoint at <coordinates>."

Issue: https://khanacademy.atlassian.net/browse/LEMS-2782

Test plan:
`yarn jest packages/perseus/src/widgets/interactive-graphs/graphs/circle.test.tsx`

Storybook
- http://localhost:6006/?path=/story/perseuseditor-widgets-interactive-graph--interactive-graph-circle
@nishasy nishasy self-assigned this Feb 19, 2025
@nishasy nishasy marked this pull request as ready for review February 19, 2025 00:14
Copy link
Contributor

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (ba885af) and published it to npm. You
can install it using the tag PR2250.

Example:

yarn add @khanacademy/perseus@PR2250

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR2250

Copy link
Contributor

Size Change: +81 B (+0.01%)

Total Size: 1.47 MB

Filename Size Change
packages/perseus/dist/es/index.js 368 kB +48 B (+0.01%)
packages/perseus/dist/es/strings.js 6.61 kB +33 B (+0.5%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 86.9 kB
packages/math-input/dist/es/index.js 77.7 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 48.2 kB
packages/perseus-editor/dist/es/index.js 689 kB
packages/perseus-linter/dist/es/index.js 22.1 kB
packages/perseus-score/dist/es/index.js 115 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.5 kB

compressed-size-action

Copy link
Member

@catandthemachines catandthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's go 😉

@nishasy nishasy merged commit f6795c2 into main Feb 24, 2025
8 checks passed
@nishasy nishasy deleted the update-strings-circle branch February 24, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants