[SR] Update Linear System strings #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're doing a final pass on strings now at the end of the phase 1 interactive graph screen reader work. - Linear system graph descriptions should include the point of intersection between the two lines. - Linear system lines' grab handle labels should have minimal line info instead of just repeating the description. Issue: https://khanacademy.atlassian.net/browse/LEMS-2782 Test plan: `yarn jest packages/perseus/src/widgets/interactive-graphs/graphs/linear-system.test.tsx` Storybook - http://localhost:6006/?path=/story/perseuseditor-widgets-interactive-graph--interactive-graph-linear-system
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (67b38dc) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2252If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2252 |
|
Size Change: +264 B (+0.02%) Total Size: 1.47 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We're doing a final pass on strings now at the end of the phase 1
interactive graph screen reader work.
between the two lines.
instead of just repeating the description.
Issue: https://khanacademy.atlassian.net/browse/LEMS-2782
Test plan:
yarn jest packages/perseus/src/widgets/interactive-graphs/graphs/linear-system.test.tsxStorybook