[mr-right] Fix issue related to Marathi Language in getDecimalSeparator #2255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marathi returns non-Arabic digits when using `Intl.NumberFormat(locale)`, which was resulting in our keypad typing the wrong character. This has been fixed by adding the Devangari digit to the logic. I've run a local test with our supported languages to ensure no other languages are facing a similar issue. I have also added some new tests for this function to help cover the main edge cases. I could be persuaded to add a list of the supported locales and expected outcomes, but that seemed like overkill and something that would be hard to keep "up to date" should the upstream standard change, or KA add more languages. Issue: LEMS-2878 Test plan: - Tests Pass - New Tests - Manual Testing
…etDecimalSeparator
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (ce56aaa) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2255If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2255 |
|
Size Change: +48 B (0%) Total Size: 1.47 MB
ℹ️ View Unchanged
|
mark-fitzgerald
approved these changes
Feb 19, 2025
…uage for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Marathi returns non-Arabic digits when using
Intl.NumberFormat(locale), which was resulting in our keypad typing the wrong character.This has been fixed by adding the Devanagari digit to the match logic. I've run a local test with all of our supported languages to ensure no other languages are facing a similar issue.
I have also added some new tests for this function to help cover the main edge cases. I could be persuaded to add a list of the supported locales and expected outcomes, but that seemed like overkill and something that would be hard to keep "up to date" should the upstream standard change, or KA add more languages.
Issue: LEMS-2878
Test plan: