Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Interactive Graph] Polygon side snapping is keyboard accessible. #2270

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

catandthemachines
Copy link
Member

@catandthemachines catandthemachines commented Feb 25, 2025

Summary:

Updating Polygon interactive graph implementation to have keyboard accessible side snapping. This is done by hooking up the side snapping behavior into a constraint function to make to keyboard arrow keys.

Issue: LEMS-2243

Test plan:

  • Go to: /?path=/story/perseuseditor-widgets-interactive-graph--interactive-graph-polygon
  • Set Snap to: to side measures
  • Use your keyboard (tab and arrow keys) to move the various polygon points.
  • Notice they now move!

@catandthemachines catandthemachines self-assigned this Feb 25, 2025
Copy link
Contributor

github-actions bot commented Feb 25, 2025

Size Change: +1.33 kB (+0.15%)

Total Size: 874 kB

Filename Size Change
packages/perseus/dist/es/index.js 369 kB +1.33 kB (+0.36%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39.5 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 11.1 kB
packages/math-input/dist/es/index.js 78.2 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 29.8 kB
packages/perseus-editor/dist/es/index.js 276 kB
packages/perseus-linter/dist/es/index.js 22.8 kB
packages/perseus-score/dist/es/index.js 20.6 kB
packages/perseus/dist/es/strings.js 6.74 kB
packages/pure-markdown/dist/es/index.js 4.14 kB
packages/simple-markdown/dist/es/index.js 13.1 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Feb 25, 2025

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (dc422cf) and published it to npm. You
can install it using the tag PR2270.

Example:

pnpm add @khanacademy/perseus@PR2270

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR2270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant