Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WB-1856] Focus: Define general pattern for focus indicators in all components #2480

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jandrade
Copy link
Member

Summary:

  • Tokens: Renamed border.focus to focus.outer and added a new focus.inner token.
  • Switch all components to use a new focus.outer semanticColor token.

Issue: WB-1856

Test plan:

Verify that all components have the correct focus indicator color.

@jandrade jandrade self-assigned this Feb 24, 2025
Copy link

changeset-bot bot commented Feb 24, 2025

🦋 Changeset detected

Latest commit: 5d383bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@khanacademy/wonder-blocks-icon-button Patch
@khanacademy/wonder-blocks-accordion Patch
@khanacademy/wonder-blocks-clickable Patch
@khanacademy/wonder-blocks-dropdown Patch
@khanacademy/wonder-blocks-button Patch
@khanacademy/wonder-blocks-switch Patch
@khanacademy/wonder-blocks-tokens Patch
@khanacademy/wonder-blocks-modal Patch
@khanacademy/wonder-blocks-form Patch
@khanacademy/wonder-blocks-link Patch
@khanacademy/wonder-blocks-pill Patch
@khanacademy/wonder-blocks-banner Patch
@khanacademy/wonder-blocks-popover Patch
@khanacademy/wonder-blocks-search-field Patch
@khanacademy/wonder-blocks-cell Patch
@khanacademy/wonder-blocks-birthday-picker Patch
@khanacademy/wonder-blocks-breadcrumbs Patch
@khanacademy/wonder-blocks-grid Patch
@khanacademy/wonder-blocks-labeled-field Patch
@khanacademy/wonder-blocks-layout Patch
@khanacademy/wonder-blocks-progress-spinner Patch
@khanacademy/wonder-blocks-toolbar Patch
@khanacademy/wonder-blocks-tooltip Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Size Change: +150 B (+0.15%)

Total Size: 98 kB

Filename Size Change
packages/wonder-blocks-accordion/dist/es/index.js 3.55 kB +7 B (+0.2%)
packages/wonder-blocks-button/dist/es/index.js 4.37 kB +61 B (+1.42%)
packages/wonder-blocks-clickable/dist/es/index.js 3.06 kB +3 B (+0.1%)
packages/wonder-blocks-dropdown/dist/es/index.js 19.5 kB +3 B (+0.02%)
packages/wonder-blocks-form/dist/es/index.js 6.05 kB +16 B (+0.27%)
packages/wonder-blocks-icon-button/dist/es/index.js 3.15 kB +40 B (+1.29%)
packages/wonder-blocks-link/dist/es/index.js 2.04 kB +1 B (+0.05%)
packages/wonder-blocks-modal/dist/es/index.js 5.5 kB +2 B (+0.04%)
packages/wonder-blocks-pill/dist/es/index.js 1.49 kB +9 B (+0.61%)
packages/wonder-blocks-switch/dist/es/index.js 2 kB +2 B (+0.1%)
packages/wonder-blocks-tokens/dist/es/index.js 2.52 kB +6 B (+0.24%)
ℹ️ View Unchanged
Filename Size
packages/wonder-blocks-banner/dist/es/index.js 1.55 kB
packages/wonder-blocks-birthday-picker/dist/es/index.js 1.82 kB
packages/wonder-blocks-breadcrumbs/dist/es/index.js 886 B
packages/wonder-blocks-cell/dist/es/index.js 2.01 kB
packages/wonder-blocks-core/dist/es/index.js 2.85 kB
packages/wonder-blocks-data/dist/es/index.js 6.25 kB
packages/wonder-blocks-grid/dist/es/index.js 1.36 kB
packages/wonder-blocks-icon/dist/es/index.js 873 B
packages/wonder-blocks-labeled-field/dist/es/index.js 1.22 kB
packages/wonder-blocks-layout/dist/es/index.js 1.82 kB
packages/wonder-blocks-popover/dist/es/index.js 4.92 kB
packages/wonder-blocks-progress-spinner/dist/es/index.js 1.52 kB
packages/wonder-blocks-search-field/dist/es/index.js 1.33 kB
packages/wonder-blocks-testing-core/dist/es/index.js 3.73 kB
packages/wonder-blocks-testing/dist/es/index.js 1.07 kB
packages/wonder-blocks-theming/dist/es/index.js 679 B
packages/wonder-blocks-timing/dist/es/index.js 1.79 kB
packages/wonder-blocks-toolbar/dist/es/index.js 923 B
packages/wonder-blocks-tooltip/dist/es/index.js 7.01 kB
packages/wonder-blocks-typography/dist/es/index.js 1.23 kB

compressed-size-action

Copy link
Contributor

A new build was pushed to Chromatic! 🚀

https://5e1bf4b385e3fb0020b7073c-saahpunkov.chromatic.com/

Chromatic results:

Metric Total
Captured snapshots 381
Tests with visual changes 19
Total stories 566
Inherited (not captured) snapshots [TurboSnap] 0
Tests on the build 381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant