Properly designate vkGetPhysicalDeviceToolProperties as a device entry-point. #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2435 implemented
VK_EXT_tooling_infousing the existing entry-point definition ofvkGetPhysicalDeviceToolProperties, but missed that the entry point had previously been misclassified as an instance entry-point instead of a device entry-point. According to the spec, as well as the extension definition in MoltenVK, it is a device extension, not an instance extension.This PR fixes the issue by re-classifying as a device entry-point. It also happens to fix that it was being added with a KHR suffix instead of EXT. I seem to have missed this as it only causes problems when linking with MoltenVK directly without the
libvulkanloader.