Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix negative_create_command_buffer_not_supported_properties test #2248

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix negative_create_command_buffer_not_supported_properties test #2248

wants to merge 4 commits into from

Conversation

bashbaug
Copy link
Contributor

fixes #2247

  • For the negative_create_command_buffer_not_supported_properties test, the only property we can check for is simultaneous use. All other properties are part of other extensions and hence will generate CL_INVALID_VALUE, not CL_INVALID_PROPERTY.
  • Checks whether the cl_khr_command_buffer_multi_device extension is supported when using CL_COMMAND_BUFFER_DEVICE_SIDE_SYNC_KHR, instead of device_side_enqueue_support.
  • If the cl_khr_command_buffer_multi_device extension is NOT supported and the CL_COMMAND_BUFFER_DEVICE_SIDE_SYNC_KHR command buffer creation flag is used, the expected error code is CL_INVALID_VALUE, not CL_INVALID_PROPERTY.

EwanC
EwanC approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwanC EwanC EwanC approved these changes

Assignees
No one assigned
Labels
focused review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

command buffer negative_create_command_buffer_not_supported_properties is incorrect
2 participants
@bashbaug @EwanC