Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate cl_ext_image_from_buffer into unified specification #1299

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Integrate cl_ext_image_from_buffer into unified specification #1299

merged 4 commits into from
Jan 24, 2025

Conversation

kpet
Copy link
Contributor

@kpet kpet commented Jan 15, 2025

Also add version notes for all CL_IMAGE_REQUIREMENTS_* enums.

Change-Id: I7b7b093034121a9215786beff7318b18e7d0c24a

@kpet
Integrate cl_ext_image_from_buffer into unified specification
8cb6cfd 
Also add version notes for all CL_IMAGE_REQUIREMENTS_* enums.

Signed-off-by: Kevin Petit <[email protected]>
Change-Id: I7b7b093034121a9215786beff7318b18e7d0c24a
bashbaug
bashbaug reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few comments.

I'd be OK merging this as-is, but we really ought to fix the formatting issue first.

api/opencl_runtime_layer.asciidoc Outdated Show resolved Hide resolved
api/footnotes.asciidoc Outdated Show resolved Hide resolved
api/cl_ext_image_from_buffer.asciidoc Outdated Show resolved Hide resolved
kpet and others added 2 commits January 24, 2025 09:56
@kpet
Copy link
Contributor Author

kpet commented Jan 24, 2025

Thanks for the review and suggestions. I've applied them. PTAL.

bashbaug
bashbaug approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We should try to remember to update the link to this extension on the OpenCL extension registry when we publish a new version of the unified spec with this extension integrated.

@bashbaug bashbaug merged commit 49da4dc into KhronosGroup:main Jan 24, 2025
2 checks passed
@kpet kpet deleted the cl-ext-image-from-buffer branch January 24, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashbaug bashbaug bashbaug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpet @bashbaug