Prevent unnecessary copies.

KhronosGroup · Nov 13, 2024 · b5c40b0 · b5c40b0
1 parent 15fd1cc
commit b5c40b0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/lib/SPIRV/SPIRVReader.cpp b/lib/SPIRV/SPIRVReader.cpp
@@ -3220,7 +3220,7 @@ Function *SPIRVToLLVM::transFunction(SPIRVFunction *BF, unsigned AS) {
     // search for a previous function with the same name
     // upgrade it to a kernel and drop this if it's found
     for (auto &I : FuncMap) {
-      auto BFName = I.getFirst()->getName();
+      const auto &BFName = I.getFirst()->getName();
       if (BF->getName() == BFName) {
         auto *F = I.getSecond();
         F->setCallingConv(CallingConv::SPIR_KERNEL);

diff --git a/lib/SPIRV/SPIRVWriter.cpp b/lib/SPIRV/SPIRVWriter.cpp
@@ -1338,7 +1338,8 @@ SPIRVValue *LLVMToSPIRVBase::transConstantUse(Constant *C,
           Ops = getVec(PtrTy->getId(), Ops);
         }
       }
-      return BM->addPtrAccessChainInst(ExpectedType, Ops, nullptr, true);
+      return BM->addPtrAccessChainInst(ExpectedType, std::move(Ops), nullptr,
+                                       true);
     }
   }
 
@@ -1470,7 +1471,7 @@ SPIRVValue *LLVMToSPIRVBase::transConstant(Value *V) {
           Ops = getVec(PtrTy->getId(), Ops);
         }
       }
-      return BM->addPtrAccessChainInst(TranslatedTy, Ops, nullptr,
+      return BM->addPtrAccessChainInst(TranslatedTy, std::move(Ops), nullptr,
                                        GEP->isInBounds());
     }
     auto *Inst = ConstUE->getAsInstruction();
@@ -2569,8 +2570,8 @@ LLVMToSPIRVBase::transValueWithoutDecoration(Value *V, SPIRVBasicBlock *BB,
       // access chain instructions. Replace return type to do that.
       TranslatedTy = SPVPointerOperand->getType();
 
-    return mapValue(
-        V, BM->addPtrAccessChainInst(TranslatedTy, Ops, BB, GEP->isInBounds()));
+    return mapValue(V, BM->addPtrAccessChainInst(TranslatedTy, std::move(Ops),
+                                                 BB, GEP->isInBounds()));
   }
 
   if (auto *Ext = dyn_cast<ExtractElementInst>(V)) {
@@ -4320,7 +4321,7 @@ SPIRVValue *LLVMToSPIRVBase::transIntrinsicInst(IntrinsicInst *II,
       Zero = BM->addConstant(ResTy, 0);
       APInt MinusOneValue(ResTy->getIntegerBitWidth(), 0, 1);
       MinusOneValue.setAllBits();
-      MinusOne = BM->addConstant(ResTy, MinusOneValue);
+      MinusOne = BM->addConstant(ResTy, std::move(MinusOneValue));
     }
 
     Op OC1 = (IID == Intrinsic::scmp) ? OpSLessThanEqual : OpULessThanEqual;