Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPIR-V 1.4] Allow OpCopyMemorySized to have Memory Operands for both Source and Target #2470

Merged
merged 5 commits into from
Apr 3, 2024
Merged

[SPIR-V 1.4] Allow OpCopyMemorySized to have Memory Operands for both Source and Target #2470

merged 5 commits into from
Apr 3, 2024

Conversation

vmaksimo
Copy link
Contributor

@vmaksimo vmaksimo commented Apr 2, 2024

This change addresses p.4 of #2460.
No changes for OpCopyMemory as we currently don't use it in translation.

@vmaksimo vmaksimo marked this pull request as draft April 2, 2024 13:09
@vmaksimo vmaksimo marked this pull request as ready for review April 2, 2024 16:59
@vmaksimo
Copy link
Contributor Author

vmaksimo commented Apr 2, 2024

Please take a look @MrSidims @LU-JOHN @asudarsa @bwlodarcz @VyacheslavLevytskyy

svenvh
svenvh reviewed Apr 3, 2024
View reviewed changes
Copy link
Member

@svenvh svenvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this! I have just one small naming suggestion.

lib/SPIRV/SPIRVWriter.cpp Outdated Show resolved Hide resolved
MrSidims
MrSidims approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@MrSidims MrSidims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! BTW it's worth cherry-picking in older branches

@MrSidims MrSidims merged commit a384e03 into KhronosGroup:main Apr 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrSidims MrSidims MrSidims approved these changes

@svenvh svenvh svenvh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmaksimo @svenvh @MrSidims