Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport to 18] add reverse translation for OpDecorateString and OpMemberDecorateString #2774

Merged
merged 1 commit into from
Oct 23, 2024
Merged

[Backport to 18] add reverse translation for OpDecorateString and OpMemberDecorateString #2774

merged 1 commit into from
Oct 23, 2024

Commits on Oct 22, 2024

  1. [Backport to 18] add reverse translation for OpDecorateString and OpM… 

    …emberDecorateString (KhronosGroup#2677)

This PR adds "reverse translation" (from SPIR-V to LLVM IR) support for OpDecorateString and OpMemberDecorateString, see KhronosGroup#2460 and KhronosGroup#2670. These instructions are currently treated as synonyms for OpDecorate and OpMemberDecorate. We'll want to tidy this up at some point, but at least for now we won't crash if we see these instructions.

I'll still need to add proper support for decorating variables in the input storage class for KhronosGroup#2670, but I'll do that in a separate PR.

(cherry picked from commit f7057b4)
    @bashbaug @svenvh
    bashbaug authored and svenvh committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    7fad3a0 View commit details
    Browse the repository at this point in the history