Improve matrices translation with SPV_KHR_untyped_pointers #2857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmaksimo
changed the title
MrSidims
reviewed
Nov 14, 2024
| ; CHECK-SPIRV: UntypedAccessChainKHR [[#TypePtr]] [[#Res:]] [[#TypeMatrix]] [[#VarMatrixPtr]] [[#Const1]] | ||
| ; CHECK-SPIRV: Store [[#Res]] [[#Const42]] | ||
|
|
||
| ; CHECK-LLVM: %0 = alloca target("spirv.CooperativeMatrixKHR", i32, 3, 12, 12, 0) |
There was a problem hiding this comment.
Suggested change
| ; CHECK-LLVM: %0 = alloca target("spirv.CooperativeMatrixKHR", i32, 3, 12, 12, 0) | |
| ; CHECK-LLVM: %[[#Matrix:]] = alloca target("spirv.CooperativeMatrixKHR", i32, 3, 12, 12, 0) |
and so on
There was a problem hiding this comment.
It's basically just a copy of access_store.ll test :) do we need these checks there too?
| else if (RetTy->isVectorTy()) | ||
| Ty = cast<VectorType>(RetTy)->getElementType(); | ||
| else | ||
| Ty = RetTy; |
There was a problem hiding this comment.
So for store pointer parameter would be considered as void *? If so it doesn't feel right, can we instead query type of the value operand of the store?
There was a problem hiding this comment.
Sorry, I don't get this at all. Don't we already query the type from the llvm instructions? Or do you mean specific SPIR-V opcode in mind?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that we do correct translation of matrices (
SPV_KHR_cooperative_matrixandSPV_INTEL_joint_matrixextensions) when untyped pointers are enabled.This mainly fixes mangling issues in reverse translation for the untyped pointer.
Also added handling for typed and untyped SPIR-V friendly access chain instructions in forward translation (a point to review and discuss).