Fix pairing of functions by type. #5227
Open
+230
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ShabbyX Can you please review this? |
|
Thanks for the fix. It looks like this didn't affect the test results so it's not covered by any tests. Could you please add tests to make sure this isn't regressed in the future? |
|
Converted to draft until it's got test coverage. |
jimblandy
force-pushed
the
more-id-pairing
branch
from
2fd1d5e to
6226f04
Compare
|
Hi @jimblandy did you happen to get a chance to get this PR to the finish line? |
jimblandy
force-pushed
the
more-id-pairing
branch
from
6226f04 to
e1a6e1e
Compare
|
|
jimblandy
force-pushed
the
more-id-pairing
branch
from
e1a6e1e to
659cc54
Compare
|
@ShabbyX I finally got around to writing a test for this (because I ran into it again and debugged it a second time 😢). PTAL. |
Change `Differ::MatchFunctions` to use `GroupIdsAndMatchByMappedId`, instead of calling `GroupIdsAndMatch` with `Differ::GroupIdsHelperGetTypeId`, which is never correct: doing so compares src and dst type ids directly, rather than consulting the established mapping. Fixes KhronosGroup#5226.
jimblandy
force-pushed
the
more-id-pairing
branch
from
659cc54 to
1a734d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Differ::MatchFunctionsto useGroupIdsAndMatchByMappedId, instead of callingGroupIdsAndMatchwithDiffer::GroupIdsHelperGetTypeId, which is never correct: doing so compares src and dst type ids directly, rather than consulting the established mapping.Depends on #5225.
Fixes #5226.