Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

printf: Remove stage specific info #5495

Merged

Conversation

jeremyg-lunarg
Copy link
Contributor

No description provided.

@jeremyg-lunarg jeremyg-lunarg marked this pull request as draft November 30, 2023 21:15
@jeremyg-lunarg jeremyg-lunarg force-pushed the jeremyg-printf-stages branch 2 times, most recently from 05b1e7a to 6088455 Compare November 30, 2023 22:13
jeremyg-lunarg added a commit to jeremyg-lunarg/Vulkan-ValidationLayers that referenced this pull request Dec 1, 2023
Remove stage specific debug info that is only needed by GPU-AV.
This allows debug printfs to be used in multi stage shader modules.

Requires KhronosGroup/SPIRV-Tools#5495

Fixes KhronosGroup#4350
@jeremyg-lunarg jeremyg-lunarg marked this pull request as ready for review December 1, 2023 23:07
jeremyg-lunarg added a commit to jeremyg-lunarg/Vulkan-ValidationLayers that referenced this pull request Dec 4, 2023
Remove stage specific debug info that is only needed by GPU-AV.
This allows debug printfs to be used in multi stage shader modules.

Requires KhronosGroup/SPIRV-Tools#5495

Fixes KhronosGroup#4350
Remove stage specific debug info that is only needed by GPU-AV.
This allows debug printfs to be used in multi-stage shader modules.

Fixes KhronosGroup#4892
@jeremyg-lunarg jeremyg-lunarg merged commit b5d6082 into KhronosGroup:main Dec 4, 2023
6 checks passed
@jeremyg-lunarg jeremyg-lunarg deleted the jeremyg-printf-stages branch December 4, 2023 22:43
jeremyg-lunarg added a commit to jeremyg-lunarg/Vulkan-ValidationLayers that referenced this pull request Dec 4, 2023
Remove stage specific debug info that is only needed by GPU-AV.
This allows debug printfs to be used in multi stage shader modules.

Requires KhronosGroup/SPIRV-Tools#5495

Fixes KhronosGroup#4350
jeremyg-lunarg added a commit to jeremyg-lunarg/Vulkan-ValidationLayers that referenced this pull request Dec 4, 2023
Remove stage specific debug info that is only needed by GPU-AV.
This allows debug printfs to be used in multi stage shader modules.

Requires KhronosGroup/SPIRV-Tools#5495

Fixes KhronosGroup#4350

Also includes the VUL linking change from KhronosGroup#7050
jeremyg-lunarg added a commit to KhronosGroup/Vulkan-ValidationLayers that referenced this pull request Dec 5, 2023
Remove stage specific debug info that is only needed by GPU-AV.
This allows debug printfs to be used in multi stage shader modules.

Requires KhronosGroup/SPIRV-Tools#5495

Fixes #4350

Also includes the VUL linking change from #7050
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants