spirv-opt: Fix OpCompositeExtract relaxation with struct operands #5536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the
ConvertToHalf
pass, anOpCompositeExtract
instruction with aOpTypeStruct
operand should not be demoted to half. This was (partially) fixed in #5201. However, that PR did not address a couple of scenarios:OpCompositeExtract
instruction is explicitly decorated withRelaxedPrecision
.OpCompositeExtract
instruction's usages are also relaxed (or it has no uses), so it is automatically decorated withRelaxedPrecision
. See this block in convert_to_half_pass.cpp.Otherwise, spirv-opt ends up generating SPIR-V which does not pass validation:
This PR is an attempt to address these issues by more strictly disallowing an
OpCompositeExtract
instruction to be demoted to half precision if it has aOpTypeStruct
operand.