spirv-val: Validate PhysicalStorageBuffer Stage Interface #5539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencer-lunarg
force-pushed
the
spencer-lunarg-psb
branch
from
8150a3d to
1870546
Compare
alan-baker
reviewed
Feb 1, 2024
spencer-lunarg
force-pushed
the
spencer-lunarg-psb
branch
from
1870546 to
2195da0
Compare
alan-baker
approved these changes
Feb 12, 2024
This was referenced Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was decided in https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/6344 that
PhysicalStorageBuffershould not be allowed to be in theInput/Outputas it would greatly complicate theLocationmatching logic and there isn't strong testing (or any spec language) around all the edge cases currently... for those who still want to pass it between stages, the simple workaround is to just pass auint64/uvec2between stagesThere is a tracker to fix the very few CTS coverage that might be violating this https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/4896
I assume there will be desire for a glslang change, but first wanted to get the
spirv-vallogic up