-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tooling support for SPV_KHR_maximal_reconvergence #5542
Merged
alan-baker
merged 12 commits into
KhronosGroup:main
from
alan-baker:dneto-spv-khr-maximal-reconvergence
Jan 25, 2024
Merged
Add tooling support for SPV_KHR_maximal_reconvergence #5542
alan-baker
merged 12 commits into
KhronosGroup:main
from
alan-baker:dneto-spv-khr-maximal-reconvergence
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pass will add or remove execution mode from all entry points in the module
* Entry point references do not include the entry point * Check for loop merge in the block was incorrect * Check of uses was too strict
dneto0
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs the DEPS update to make the bots pass.
But LGTM!
* Fix formatting * Minor review change * Fix test for header update
It looks like you might have missed adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on KhronosGroup/SPIRV-Headers#407. I will update the deps after it is merged.
Adds tooling support for SPV_KHR_maximal_reconvergence