Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPV_AMDX_shader_enqueue version 2 support #5838

Merged
merged 10 commits into from
Jan 17, 2025

Conversation

yavn
Copy link
Contributor

@yavn yavn commented Oct 4, 2024

@alan-baker
Copy link
Contributor

Could you please rebase on main and update the spirv-headers hash in DEPS to point to at least the merged headers for this extension?

* Update SPIRV-Headers

Co-authored-by: Dan Brown <[email protected]>
Co-authored-by: Maciej Jesionowski <[email protected]>
@yavn yavn force-pushed the SPV_AMDX_shader_enqueue_v2 branch from 6e411f5 to bef6468 Compare October 9, 2024 20:10
@yavn
Copy link
Contributor Author

yavn commented Oct 9, 2024

Hi @alan-baker , done and done.

Copy link
Contributor

@alan-baker alan-baker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall there seem to be a lack of tests for this functionality. Please add some tests for the new validation.

Separately, when reading the spec for this extension you seem to be validating things that are missing from the spec. I'd suggest double checking and updating the extension text to match this validation.

Copy link
Collaborator

@s-perron s-perron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The optimizer changes look good to me.

@alan-baker
Copy link
Contributor

@yavn could you please rebase this change and fix the formatting and any build errors?

@yavn
Copy link
Contributor Author

yavn commented Jan 16, 2025

I'll see if there are any new failures once the checks are done. I used merges during the review, so please squash it on submit if a linear history is preferred. Thanks.

@alan-baker
Copy link
Contributor

The asan failure looks real. The smoketest should be resolved with another rebase.

@yavn
Copy link
Contributor Author

yavn commented Jan 16, 2025

Thanks for taking a look. Okay, it's probably due to that nested new at test/opt/type_manager_test.cpp:182:32. I will fix it tomorrow.

@s-perron s-perron enabled auto-merge (squash) January 17, 2025 14:34
@s-perron s-perron disabled auto-merge January 17, 2025 14:34
@s-perron s-perron enabled auto-merge (squash) January 17, 2025 14:34
@s-perron s-perron merged commit b9d5ced into KhronosGroup:main Jan 17, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants