-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SPV_AMDX_shader_enqueue version 2 support #5838
Conversation
Could you please rebase on main and update the spirv-headers hash in DEPS to point to at least the merged headers for this extension? |
* Update SPIRV-Headers Co-authored-by: Dan Brown <[email protected]> Co-authored-by: Maciej Jesionowski <[email protected]>
6e411f5
to
bef6468
Compare
Hi @alan-baker , done and done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall there seem to be a lack of tests for this functionality. Please add some tests for the new validation.
Separately, when reading the spec for this extension you seem to be validating things that are missing from the spec. I'd suggest double checking and updating the extension text to match this validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The optimizer changes look good to me.
@yavn could you please rebase this change and fix the formatting and any build errors? |
I'll see if there are any new failures once the checks are done. I used merges during the review, so please squash it on submit if a linear history is preferred. Thanks. |
The asan failure looks real. The smoketest should be resolved with another rebase. |
Thanks for taking a look. Okay, it's probably due to that nested new at |
The relevant SPIR-V changes are posted in the following PRs: