Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add khr_queue_empty tests #1031

Merged
merged 13 commits into from
Feb 6, 2025
Merged

Add khr_queue_empty tests #1031

merged 13 commits into from
Feb 6, 2025

Conversation

TApplencourt
Copy link
Contributor

@TApplencourt TApplencourt commented Jan 30, 2025

@TApplencourt TApplencourt requested a review from a team as a code owner January 30, 2025 17:35
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix formatting issues and add CTS option to the root CMake file like this: https://github.com/KhronosGroup/SYCL-CTS/blob/main/CMakeLists.txt#L113-L115

@TApplencourt
Copy link
Contributor Author

Thanks a lot, sorry for the sloppy copy/pasting.

@TApplencourt TApplencourt force-pushed the khr_queue_empty_query branch from 5582758 to 57f9966 Compare January 30, 2025 19:35
Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test.

tests/extension/khr_queue_empty_query/queue_empty.cpp Outdated Show resolved Hide resolved
tests/extension/khr_queue_empty_query/queue_empty.cpp Outdated Show resolved Hide resolved
@tomdeakin
Copy link
Contributor

WG approved to merge

@tomdeakin tomdeakin merged commit aa2045e into main Feb 6, 2025
9 checks passed
@bader bader deleted the khr_queue_empty_query branch February 6, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants