Fix the CullPrimitiveEXT VUID's

[pmistryNV]

• Remove VUID 07037 that wrongly was needing the builtin to be of type array
• Updated the VUID 7036 to make the type a boolean value

Fixes bug https://gitlab.khronos.org/vulkan/vulkan/-/issues/3296

[CLAassistant]

All committers have signed the CLA.

[dgkoch]

LGTM

[HansKristian-Work]

I don't think this is correct.

When CullPrimitiveEXT is part of a Block, it must be a plain bool, but if it's declared as a standalone OpVariable, i.e. not in a Block, it must be an array of booleans, so I think this VUID needs to cover both cases.

[HansKristian-Work]

Not correct I think as stated above.

[pmistryNV]

Not correct I think as stated above.

GLSL spec has folowing definition

      // write only access
      perprimitiveEXT out gl_MeshPerPrimitiveEXT {
        int  gl_PrimitiveID;
        int  gl_Layer;
        int  gl_ViewportIndex;
        bool gl_CullPrimitiveEXT;
        int  gl_PrimitiveShadingRateEXT;
      } gl_MeshPrimitivesEXT[];

Then the array validation rule will applly to all the other builtins like PrimitiveId , Layer etc? Because currently none of the other builtins have such a validation rule

[pmistryNV]

Not correct I think as stated above.

GLSL spec has folowing definition

      // write only access
      perprimitiveEXT out gl_MeshPerPrimitiveEXT {
        int  gl_PrimitiveID;
        int  gl_Layer;
        int  gl_ViewportIndex;
        bool gl_CullPrimitiveEXT;
        int  gl_PrimitiveShadingRateEXT;
      } gl_MeshPrimitivesEXT[];

Then the array validation rule will applly to all the other builtins like PrimitiveId , Layer etc? Because currently none of the other builtins have such a validation rule

We will then probably need new VUID's for each of the above builtins. Kindly review these three new VUID's for CullPrimitiveEXT, i can replicate it for all the other builtins:

• CullPrimitiveEXT can be member of a block or a variable
• If CullPrimitiveEXT is a variable it must be declared as an array of boolean values
• If CullPrimitiveEXT is member of a block it must be declared as a boolean value

[pmistryNV]

• If CullPrimitiveEXT is a variable it must be declared as an array of boolean values

@HansKristian-Work can you review the new VUID's. Based on how they look, I will add VUID's for other builtins defined in gl_MeshPerPrimitiveEXT

[HansKristian-Work]

Suggested change

	code:CullPrimitiveEXT must: be declared as a boolean value member of a structure or a variable of type code:OpTypeArray of boolean values.
	* If code:CullPrimitiveEXT declared as an array of boolean values. The size of the array
	decorated with code:CullPrimitiveEXT must: match the value specified by code:OutputPrimitivesEXT
	* If code:CullPrimitiveEXT is a member of a structure, there must: be a variable declared
	which is array of parent strucure that contains code:CullPrimitiveEXT. The size of the array must: match the value specified by code:OutputPrimitivesEXT.
	* There must be only one declaration of the code:CullPrimitiveEXT associated with a entry
	point's interface.
	code:CullPrimitiveEXT must: decorate a scalar boolean member of a structure decorated as code:Block, or decorate a variable of type code:OpTypeArray of boolean values.
	* If code:CullPrimitiveEXT is declared as an array of boolean values, the size of the array
	must: match the value specified by code:OutputPrimitivesEXT
	* If code:CullPrimitiveEXT decorates a member of a structure, the variable declaration of the containing code:Block type must: have an array size that matches the value specified by code:OutputPrimitivesEXT
	* There must be only one declaration of the code:CullPrimitiveEXT associated with a entry
	point's interface.

[HansKristian-Work]

I think this language reads closer to the rest of the spec, but otherwise, the gist of it is fine.