Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VUID for relaxed control barrier with storage class semantics #2495

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add VUID for relaxed control barrier with storage class semantics #2495

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51700e8
Add VUID for relaxed control barrier with storage class semantics
natgavrilenko Feb 11, 2025
3ca3a93
Remove hardcoded VUID
natgavrilenko Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions appendices/spirvenv.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,10 @@ or knowledge of runtime information, such as enabled features.
code:AcquireRelease, or code:SequentiallyConsistent memory semantics
* [[VUID-{refpage}-OpMemoryBarrier-04733]]
code:OpMemoryBarrier must: include at least one {StorageClass}
* [[VUID-{refpage}-OpControlBarrier-04649]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VUIDs are assigned as part of the spec update process, so please remove this anchor.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like

  * If the semantics for code:OpControlBarrier includes at least one {StorageClass},
    then it must: include one of code:Acquire, code:Release, code:AcquireRelease,
    or code:SequentiallyConsistent memory semantics

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thank you

If the semantics for code:OpControlBarrier includes at least one {StorageClass},
then it must: include one of code:Acquire, code:Release, code:AcquireRelease,
or code:SequentiallyConsistent memory semantics
* [[VUID-{refpage}-OpControlBarrier-04650]]
If the semantics for code:OpControlBarrier includes one of code:Acquire,
code:Release, code:AcquireRelease, or code:SequentiallyConsistent memory
Expand Down
Loading