Add option to select phys device to vkcube / vkcubepp #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyk-lunarg
suggested changes
Jul 16, 2020
| @@ -3178,8 +3179,7 @@ static void demo_init_vk(struct demo *demo) { | |||
| VkPhysicalDevice *physical_devices = malloc(sizeof(VkPhysicalDevice) * gpu_count); | |||
| err = vkEnumeratePhysicalDevices(demo->inst, &gpu_count, physical_devices); | |||
| assert(!err); | |||
| /* For cube demo we just grab the first physical device */ | |||
| demo->gpu = physical_devices[0]; | |||
| demo->gpu = physical_devices[demo->gpu_number]; | |||
There was a problem hiding this comment.
This segfaults if the number selected by the user is out of bounds.
It would be cleaner if it either:
- Crashed more gracefully with an error message.
- Output a warning to the user and use the first gpu in the list.
| @@ -1215,8 +1223,7 @@ void Demo::init_vk() { | |||
| std::unique_ptr<vk::PhysicalDevice[]> physical_devices(new vk::PhysicalDevice[gpu_count]); | |||
| result = inst.enumeratePhysicalDevices(&gpu_count, physical_devices.get()); | |||
| VERIFY(result == vk::Result::eSuccess); | |||
| /* For cube demo we just grab the first physical device */ | |||
| gpu = physical_devices[0]; | |||
| gpu = physical_devices[gpu_number]; | |||
There was a problem hiding this comment.
Good point. I choose option 2.
Change-Id: Ic6ff0210b586e03597aa3418b45bf0fa57b1157c
TonyBarbour
force-pushed
the
tony-cube-phydev
branch
from
9a143ce to
fffc7bb
Compare
jeremy-lunarg
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for issue in #308