Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run Undefined runner #9453

Conversation

spencer-lunarg
Copy link
Contributor

Attempt to add a runner for Undefined Behavior for #9384

@spencer-lunarg spencer-lunarg requested a review from a team as a code owner February 17, 2025 14:06
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 373295.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 19080 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 19080 passed.

@@ -87,27 +87,34 @@ jobs:
env:
VK_KHRONOS_PROFILES_PROFILE_FILE: ${{ github.workspace }}/tests/device_profiles/min_core.json

# Make sure a debug version builds, but no need to run tests on it (since we do with release already)
linux-debug:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this remove debug build?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya, we have debug builds tested inside internal CI, we just recently demoted the Debug run to a Debug build and honestly no sure what it offers (since it is fully tested internally)

So replacing those CI minutes with an Undefined Behavior runner seems better use of the credits

Copy link
Contributor

@artem-lunarg artem-lunarg Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember details about replacing debug build, but if was about timing, then trading timing for debug build validity checks (c-runtime, stl) is a bad move in my opinion! (less related to current PR).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed, will keep the debug build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants