layers: Add missing NVSCI checking for VkMemoryAllocateInfo #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iBufInfoNV According to the doc, If the parameters define an import operation and the external handle type is VK_EXTERNAL_MEMORY_HANDLE_TYPE_SCI_BUF_BIT_NV, allocationSize is ignored. Currently VVL will report check failure on this, add the checking for VkImportMemorySciBufInfoNV to fix this problem.
|
|
psionic12
changed the title
According to the doc, If the parameters define an import operation and the external handle type is VK_EXTERNAL_MEMORY_HANDLE_TYPE_SCI_BUF_BIT_NV, allocationSize is ignored. Currently VVL will report check failure on this, add the checking for VkImportMemorySciBufInfoNV to fix this problem.
|
Abandon this since no nvsci header can be found on Windows, needs further investigation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the doc, If the parameters define an import operation
and the external handle type is
VK_EXTERNAL_MEMORY_HANDLE_TYPE_SCI_BUF_BIT_NV, allocationSize
is ignored.
Currently VVL will report check failure on this, add the checking
for VkImportMemorySciBufInfoNV to fix this problem.