Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added KBPCxxxxT Bridge #2827

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

aris-kimi
Copy link
Collaborator

@aris-kimi aris-kimi commented Jun 27, 2020

-T series from URL: https://www.diodemodule.com/bridge-rectifier/kbpc/
Footprint PRs: Mountpoint, NO_Mountpoint
Linked issue: KiCad/kicad-footprints#2311

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Jul 5, 2020
@aris-kimi aris-kimi marked this pull request as draft August 9, 2020 14:53
@myfreescalewebpage
Copy link
Collaborator

@aris-kimi I don't see commit since a while, is it still a draft ?

@aris-kimi aris-kimi marked this pull request as ready for review August 25, 2020 18:46
@aris-kimi
Copy link
Collaborator Author

I want to ask about appropriate footprint name. I do have 4 ft PRs open, 2 of them are for the part with round pins (1 with PCB hole for part mount in heatsink, 1 without this PCB hole)
also 2 of them are for the part with rectangle pins (1 with PCB hole for part mount in heatsink, 1 without this PCB hole).

Guide me for proper footprint naming, And i will update this PR with both KBPCxxxxT & KBPCxxxxW symbols.

@myfreescalewebpage
Copy link
Collaborator

I let footprint experts indicate you what is the best for that

@myfreescalewebpage
Copy link
Collaborator

Branch issue to be fixed here.

@myfreescalewebpage myfreescalewebpage self-assigned this Aug 26, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Aug 26, 2020
@myfreescalewebpage
Copy link
Collaborator

Ping me when the PR will no more be draft.
Joel

@myfreescalewebpage
Copy link
Collaborator

@aris-kimi what is the status here ?

@aris-kimi
Copy link
Collaborator Author

Hi @myfreescalewebpage , I am waiting for some footprint status update and then i will proceed. I think FP is the most "heavy" job here since then i have to change it to all (those and upcomming) additions.

I can proceed as you advise btw.

@myfreescalewebpage
Copy link
Collaborator

Do the footprint first if you prefer, it's ok

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants