Made review message optional

KieranFYI · Feb 10, 2020 · ba999f2 · ba999f2
1 parent 6f7b515
commit ba999f2
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/Pub/Controller/Bans.php b/Pub/Controller/Bans.php
@@ -162,9 +162,9 @@ public function actionReview(ParameterBag $params) {
 			if ($ban->ban_review != $input) {
 
 				$message = trim($this->plugin('XF:Editor')->fromInput('message'));
-				if (!strlen($message)) {
+				/*if (!strlen($message)) {
 					throw $this->exception($this->notFound(\XF::phrase('kieran_bans_message_required')));
-				}
+				}*/
 
 				$ban->ban_review = $input;
 				$ban->save();
@@ -295,13 +295,15 @@ public function banSaveProcess($ban) {
 
 		$form->basicEntitySave($ban, $input['ban']);
 
-		$visitor = \XF::visitor();
-		$form->basicEntitySave($ban, [
-			'admin_name' => $visitor->username,
-			'admin_id' => $this->getPrimarySteamID(),
-			'admin_user_id' => $visitor->user_id,
-			'admin_ip' => $this->app()->request()->getIp(),
-		]);
+		if ($ban->isInsert()) {
+			$visitor = \XF::visitor();
+			$form->basicEntitySave($ban, [
+				'admin_name' => $visitor->username,
+				'admin_id' => $this->getPrimarySteamID(),
+				'admin_user_id' => $visitor->user_id,
+				'admin_ip' => $this->app()->request()->getIp(),
+			]);
+		}
 
 		return $form;
 	}