Skip to content

Commit

Permalink
Perf improvements
Browse files Browse the repository at this point in the history
Windows: only do the 2 files we distribute, since they are also signed.

MacOS requires post-signing so we want to checksum all. But it's super slow. Use MD5 instead and filter the giant pointless botocore data directory.
  • Loading branch information
scosman committed Mar 1, 2025
1 parent f090933 commit 33159b1
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/build_desktop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,17 @@ jobs:

- name: Checksums (macOS)
if: runner.os == 'macOS'
run: find ./app/desktop/build/dist -type f -exec shasum -a 256 {} \;
run: find ./app/desktop/build/dist/Kiln.app ! -iname "./app/desktop/build/dist/Kiln.app/Contents/Resources/botocore/data/*" -type f -exec md5 {} \;

- name: Checksums (Linux)
if: runner.os == 'Linux'
run: find ./app/desktop/build/dist -type f -exec sha256sum {} \;

- name: Checksums (Windows)
if: runner.os == 'Windows'
run: Get-ChildItem -Path ./app/desktop/build/dist -Recurse -File | ForEach-Object { Get-FileHash -Path $_.FullName -Algorithm SHA256 | Select-Object Path,Hash }
run: |
certutil -hashfile ./app/desktop/build/dist/Kiln.Windows.Installer.exe SHA256
certutil -hashfile ./app/desktop/build/dist/Kiln/Kiln.exe SHA256
- name: Upload Build
uses: actions/upload-artifact@v4
Expand Down

0 comments on commit 33159b1

Please sign in to comment.