Windows icon as ico file

app/desktop/build_desktop_app.sh

@@ -41,30 +41,27 @@ echo "Building for $(uname)"
 if [ "$(uname)" == "Darwin" ]; then
   echo "Building MacOS app"
   cp desktop/mac_taskbar.png desktop/build/taskbar.png
-  cp desktop/mac_icon.png desktop/build/icon.png
   # onedir launches faster, and still looks like 1 file with MacOS .app bundles
-  PLATFORM_OPTS="--onedir --windowed --osx-bundle-identifier=com.kiln-ai.kiln.studio"
+  PLATFORM_OPTS="--onedir --windowed --icon=../mac_icon.png --osx-bundle-identifier=com.kiln-ai.kiln.studio"
 
   PY_PLAT=$(python -c 'import platform; print(platform.machine())')
   echo "Building MacOS app for single platform ($PY_PLAT)"
 elif [[ "$(uname)" =~ ^MINGW64_NT-10.0 ]] || [[ "$(uname)" =~ ^MSYS_NT-10.0 ]]; then
   echo "Building Windows App"
   cp desktop/win_taskbar.png desktop/build/taskbar.png
-  cp desktop/win_icon.png desktop/build/icon.png
-  PLATFORM_OPTS="--windowed --splash=../win_splash.png"
+  PLATFORM_OPTS="--windowed --splash=../win_splash.png --icon=../win_icon.ico"
 elif [ "$(uname)" == "Linux" ]; then
   echo "Building Linux App"
   cp desktop/mac_taskbar.png desktop/build/taskbar.png
-  cp desktop/mac_icon.png desktop/build/icon.png
-  PLATFORM_OPTS="--windowed --onefile --splash=../win_splash.png"
+  PLATFORM_OPTS="--windowed --onefile --splash=../win_splash.png --icon=../mac_icon.png"
 else
   echo "Unsupported operating system: $(uname)"
   exit 1
 fi
 
 # Builds the desktop app
 # TODO: use a spec instead of long winded command line
-pyinstaller $(printf %s "$PLATFORM_OPTS") --icon="./icon.png" \
+pyinstaller $(printf %s "$PLATFORM_OPTS") \
   --add-data "./taskbar.png:." --add-data "../../web_ui/build:./web_ui/build" \
   --noconfirm --distpath=./desktop/build/dist --workpath=./desktop/build/work \
   -n Kiln --specpath=./desktop/build \