Skip to content

Commit

Permalink
Try building pyinstaller
Browse files Browse the repository at this point in the history
  • Loading branch information
scosman committed Feb 10, 2025
1 parent 90380a8 commit 9db047e
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 47 deletions.
50 changes: 3 additions & 47 deletions .github/workflows/windows_release_build.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
name: Build Signed Windows Release

on:
release:
types: [created]
on: push

jobs:
build:
Expand All @@ -28,50 +26,8 @@ jobs:
- name: Install the project
run: uv sync

- name: Build Desktop App
run: uv run bash ./app/desktop/build_desktop_app.sh

- name: Sign internal files with Trusted Signing
uses: azure/[email protected]
with:
azure-tenant-id: ${{ secrets.AZURE_TENANT_ID }}
azure-client-id: ${{ secrets.AZURE_CLIENT_ID }}
azure-client-secret: ${{ secrets.AZURE_CLIENT_SECRET }}
endpoint: https://eus.codesigning.azure.net/
trusted-signing-account-name: Kiln-Steve-Signing
certificate-profile-name: Kiln-AI-Signing
files-folder: ${{ github.workspace }}/app/desktop/build/dist
files-folder-recurse: true
files-folder-filter: exe
# TODO: consider signing dlls as well. But for testing, we don't want to use all our quota.
# files-folder-filter: exe,dll
file-digest: SHA256
timestamp-rfc3161: http://timestamp.acs.microsoft.com
timestamp-digest: SHA256

- name: Build Windows Installer
uses: Minionguyjpro/[email protected]
with:
path: ./app/desktop/WinInnoSetup.iss

- name: Sign Windows Installer exe
uses: azure/[email protected]
with:
azure-tenant-id: ${{ secrets.AZURE_TENANT_ID }}
azure-client-id: ${{ secrets.AZURE_CLIENT_ID }}
azure-client-secret: ${{ secrets.AZURE_CLIENT_SECRET }}
endpoint: https://eus.codesigning.azure.net/
trusted-signing-account-name: Kiln-Steve-Signing
certificate-profile-name: Kiln-AI-Signing
files-folder: ${{ github.workspace }}/app/desktop/Output
files-folder-recurse: true
files-folder-filter: kilnsetup.exe
file-digest: SHA256
timestamp-rfc3161: http://timestamp.acs.microsoft.com
timestamp-digest: SHA256

- name: Copy Windows Installer
run: cp ./app/desktop/Output/kilnsetup.exe ./app/desktop/build/dist/Kiln.Windows.Installer.exe
- name: Build Desktop App including pyinstaller bootloader
run: uv run bash ./app/desktop/build_desktop_app.sh --build-bootloader

- name: Upload Build
uses: actions/upload-artifact@v4
Expand Down
13 changes: 13 additions & 0 deletions app/desktop/build_desktop_app.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,19 @@ if [[ $* != *--skip-web* ]]; then
cd ..
fi

if [[ $* == *--build-bootloader* ]]; then
echo "Building bootloader"
echo "path $PWD"
mkdir -p desktop/build/bootloader
cd desktop/build/bootloader
git clone [email protected]:pyinstaller/pyinstaller.git
cd pyinstaller/bootloader
python ./waf all
echo "path $PWD"
cd ../../../../..
echo "path $PWD"
fi

mkdir -p desktop/build

echo "Building for $(uname)"
Expand Down

0 comments on commit 9db047e

Please sign in to comment.