Merge pull request #19 from KinsonDigital/preview/v1.0.0-preview.3

🚀Preview Release
KinsonDigital · Dec 21, 2022 · c5d750d · c5d750d
2 parents 376c975 + 47309ca
commit c5d750d
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 4 deletions.
diff --git a/Carbonate/Carbonate.csproj b/Carbonate/Carbonate.csproj
@@ -7,10 +7,10 @@
         <Nullable>enable</Nullable>
 
         <!--Update this for production and preview releases-->
-        <Version>1.0.0-preview.2</Version>
+        <Version>1.0.0-preview.3</Version>
 
         <!--Update this for production and preview releases-->
-        <FileVersion>1.0.0-preview.2</FileVersion>
+        <FileVersion>1.0.0-preview.3</FileVersion>
 
         <!--
           DO NOT UPDATE THIS FOR PREVIEW RELEASES!!

diff --git a/Carbonate/JsonMessage.cs b/Carbonate/JsonMessage.cs
@@ -46,6 +46,8 @@ public JsonMessage(ISerializer serializer, string jsonData)
             {
                 throw new JsonException("Issues with the JSON deserialization process.");
             }
+
+            return result;
         }
         catch (Exception e)
         {

diff --git a/Documentation/ReleaseNotes/PreviewReleases/Release-Notes-v1.0.0-preview.3.md b/Documentation/ReleaseNotes/PreviewReleases/Release-Notes-v1.0.0-preview.3.md
@@ -0,0 +1,16 @@
+<h1 align="center" style='color:mediumseagreen;font-weight:bold'>
+    Carbonate Preview Release Notes - v1.0.0-preview.3
+</h1>
+
+<h2 align="center" style='font-weight:bold'>Quick Reminder</h2>
+
+<div align="center">
+
+As with all software, there is always a chance for issues and bugs, especially for preview releases, which is why your input is greatly appreciated. 🙏🏼
+</div>
+
+---
+
+<h2 style="font-weight:bold" align="center">Bug Fixes 🐛</h2>
+
+1. [#16](https://github.com/KinsonDigital/Carbonate/issues/16) - Fixed a bug where the `IMessage.GetData<T>()` would always return `null`.
diff --git a/Testing/CarbonateTests/JsonMessageTests.cs b/Testing/CarbonateTests/JsonMessageTests.cs
@@ -69,14 +69,15 @@ public void GetData_WhenInvoked_ReturnsCorrectResult()
         var sut = new JsonMessage(this.mockSerializer, "test-data");
 
         // Act
-        sut.GetData<TestData>();
+        var actual = sut.GetData<TestData>();
 
         // Assert
         this.mockSerializer.Received(1).Deserialize<TestData>("test-data");
+        actual.Should().NotBeNull();
     }
 
     [Fact]
-    public void GetData_WhenSerializationResultIsNull_ThrowsException()
+    public void GetData_WhenSerializationResultIsNull_InvokesOnErrorAction()
     {
         // Arrange
         TestData? nullData = null;
-Original file line number
+Diff line change
@@ Expand Up / @@ -46,6 +46,8 @@ public JsonMessage(ISerializer serializer, string jsonData) @@
                 {
                     throw new JsonException("Issues with the JSON deserialization process.");
                 }
+                return result;
             }
             catch (Exception e)
             {
@@ Expand Down @@