Don't auto-hide menu bar on Windows and Linux #5415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This auto-hide behavior causes the bar to toggle visible and hidden when the user hits the <kbd>Alt</kbd> key, which can be quite often especially with Trackpad Friendly controls enabled.
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pierremtb
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Oh hell yeah thank so much for fixing this @franknoirot. Been meaning to bring this up for quite some time but somehow never came around to it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This auto-hide behavior causes the bar to toggle visible and hidden when the user hits the Alt key, which can be quite often especially with Trackpad Friendly controls enabled.
Behavior in Nightly v25.2.18
https://github.com/user-attachments/assets/cbf6139d-afe0-4dfd-b876-cafc1007907e
New behavior from this branch
https://github.com/user-attachments/assets/225915d3-35ae-4cd9-aefa-b7a858d36ae1