Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Coverage type to GraphQL API #2515

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

williamjallen
Copy link
Collaborator

This PR continues our ongoing effort to expose major components of the CDash database via the GraphQL API. As of now, these changes are rather useless since the filename is not stored in the Coverage table. A future PR will migrate the filename to the underlying coverage table, and add a filename field to the Coverage GraphQL type.

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason that we aren't returning fileid? That's what is used to build the URL which shows the line-by-line coverage in the webpage, not id. Otherwise, looks good:

image

@williamjallen
Copy link
Collaborator Author

Is there a reason that we aren't returning fileid?

As a general rule, we don't expose foreign IDs directly. Instead, it's preferable to expose the relationship itself. One of my next PRs will be to add a file relationship to the Coverage type. That file type will expose its own ID.

@josephsnyder josephsnyder added this pull request to the merge queue Oct 25, 2024
Merged via the queue into Kitware:master with commit 966efdb Oct 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants