Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authz token in url + initial deployment docs #692

Merged
merged 5 commits into from
Jan 29, 2025
Merged

Authz token in url + initial deployment docs #692

merged 5 commits into from
Jan 29, 2025
+338 −216

Conversation

floryst
Copy link
Collaborator

@floryst floryst commented Jan 27, 2025

  • Adds token and tokenUrl support for obtaining authorization tokens. Tokens are currently sent with same-origin semantics for now.
  • Add initial deployment docs

Closes #689

@floryst floryst requested a review from PaulHax January 27, 2025 20:15
@netlify Netlify
Copy link

netlify bot commented Jan 27, 2025 •
edited
Loading

✅ Deploy Preview for volview-dev ready!

Name Link
🔨 Latest commit f2f56f7
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/67994f6305d5dd0008f50f39
😎 Deploy Preview https://deploy-preview-692--volview-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

PaulHax
PaulHax reviewed Jan 27, 2025
View reviewed changes
docs/authentication.md Outdated Show resolved Hide resolved
@PaulHax PaulHax linked an issue Jan 27, 2025 that may be closed by this pull request
Parse URL parameters correctly when they contain URL parameters #688
Closed
PaulHax
PaulHax reviewed Jan 27, 2025
View reviewed changes
src/utils/fetch.ts Outdated Show resolved Hide resolved
@floryst floryst added this pull request to the merge queue Jan 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jan 28, 2025
@floryst floryst force-pushed the authz-token-in-url branch from 725ac11 to f2f56f7 Compare January 28, 2025 21:42
@floryst floryst requested a review from PaulHax January 28, 2025 21:48
PaulHax
PaulHax approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@PaulHax PaulHax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖

@floryst floryst added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 7d19699 Jan 29, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulHax PaulHax PaulHax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

issue with token Authentication for ORTHANC Parse URL parameters correctly when they contain URL parameters
2 participants
@floryst @PaulHax