Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python interface #1380

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Python interface #1380

wants to merge 7 commits into from

Conversation

marySalvi
Copy link
Collaborator

@marySalvi marySalvi commented Sep 21, 2023

TODO

  • Upload annotations
    • validate file
    • upload annotation file
  • Update existing folder
    • require id
    • update/overwrite
  • Support tags
    • option for upload and update
  • Large image

Copy link
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled the branch and did some local uploads. Works well and I can upload my data using the commands after installing the CLI. The -1 for images and the girder-client requirement should probably be changed. Other than below are a list of ideas and features.

These are opinions so feel free not to implement them or get an opinion from Roni:

  • It may be nice to have the upload commands for the different type utilize arguments instead of options. I.E ascent upload image-sequence ~/dev/Samples/Fish/ FishFolderName instead of ascent upload image-sequence --path ~/dev/SamplesFish --folder-name FishFolderName. I look at options as being modifications to the basic usage where arguments represent the basic usage.
  • Have in the help a quick sample example of the command.

Feel free to push back against adding these additional features. I just wanted to list some of them so we have them in the future to go through. Some of these things I'm sure you already thought of:

  • Updating existing annotations. I.E either using a folder name (which could do a search of datasets available to the user and find a matching one) or folderId being able to push more annotations into a dataset and overwrite the existing ones.
  • Ability to download annotations by dataset name/ folder Id.
  • Multi-uploads. Being able to upload multiple datasets using single command, like a folder of videos or multiple folders of image sequences.
  • I think when the upload is complete it should return/print in the console a link to the dataset(s) that were uploaded.

ascent/ascent/cli.py Outdated Show resolved Hide resolved
ascent/setup.py Outdated Show resolved Hide resolved
ascent/ascent/cli.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants