-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python interface #1380
base: main
Are you sure you want to change the base?
Python interface #1380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled the branch and did some local uploads. Works well and I can upload my data using the commands after installing the CLI. The -1 for images and the girder-client requirement should probably be changed. Other than below are a list of ideas and features.
These are opinions so feel free not to implement them or get an opinion from Roni:
- It may be nice to have the upload commands for the different type utilize arguments instead of options. I.E
ascent upload image-sequence ~/dev/Samples/Fish/ FishFolderName
instead ofascent upload image-sequence --path ~/dev/SamplesFish --folder-name FishFolderName
. I look at options as being modifications to the basic usage where arguments represent the basic usage. - Have in the help a quick sample example of the command.
Feel free to push back against adding these additional features. I just wanted to list some of them so we have them in the future to go through. Some of these things I'm sure you already thought of:
- Updating existing annotations. I.E either using a folder name (which could do a search of datasets available to the user and find a matching one) or folderId being able to push more annotations into a dataset and overwrite the existing ones.
- Ability to download annotations by dataset name/ folder Id.
- Multi-uploads. Being able to upload multiple datasets using single command, like a folder of videos or multiple folders of image sequences.
- I think when the upload is complete it should return/print in the console a link to the dataset(s) that were uploaded.
4f75f7a
to
0472dd6
Compare
TODO