Jobserver fifo #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make space to add new API to set up token pool master.
GNU make 4.4 introduced a new jobserver style "fifo" for POSIX systems which passes a named pipe down to the clients. - update auth parser to recognize "fifo:<name>" format - open named pipe for reading and writing - make sure the file descriptors are closed in the destructor - add 2 tests that aren't compiled for WIN32
|
@bradking Can you take a look on this, or ping someone who can? |
|
@hundeboll thanks. In general we don't accept pull requests directly to this fork. It exists only to stage upstream PRs that haven't been merged there yet. This PR is toward that goal, but I'd like to avoid cherry-picking if possible. When I get a chance I'll look through the current state of the relevant upstream PRs to see if I can rebuild our fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent GNU make versions support opening a fifo path instead of using passed filedescriptor numbers. This simplifies using the jobserver functionality in build systems like openembedded.
These two patches are cherry-picked from ninja-build#2263 while skipping the patches adding joberserver master support.
A few simple conflicts were resolved in the test file while cherry-picking.