Update nrtk and pybsm version #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulHax
force-pushed
the
nrtk
branch
2 times, most recently
from
2f12ac2 to
94fb490
Compare
5 tasks
alesgenova
approved these changes
Jan 20, 2025
| @@ -152,6 +152,6 @@ def execute(self, input, *input_args): | |||
| input_args = self.exec_args | |||
|
|
|||
| input_array = np.asarray(input) | |||
| output_array = self._perturber.perturb(input_array, *input_args) | |||
| output_array, unknown = self._perturber.perturb(input_array, *input_args) | |||
There was a problem hiding this comment.
Very minor nitpick, I think the convention is to use _ for unused elements when unpacking tuples:
output_array, _ = ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR pins the versions of
nrtkandpybsm. These packages often have breaking changes. This means our testing cron job is less interesting, but keeping it still: https://github.com/Kitware/nrtk-explorer/blob/main/.github/workflows/ci.yml#L7closes #152
After release on PiPy, update Conda feedstock: conda-forge/nrtk-explorer-feedstock#16