Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (explorer consistency): Making explorer name and constructor arguments consistent #154

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

ayenpure
Copy link
Collaborator

@ayenpure ayenpure commented Jan 6, 2025

Making the explorers more consistent in naming and behavior

@ayenpure ayenpure requested a review from jourdain January 6, 2025 21:58
Copy link
Collaborator

@jourdain jourdain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current code is good but you are forgetting to update that section

https://github.com/Kitware/pan3d/blob/main/pyproject.toml#L69-L74

@jourdain jourdain self-requested a review January 6, 2025 22:48
Copy link
Collaborator

@jourdain jourdain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the file name did not change and since the main method is what is getting executed, you are fine.

@jourdain jourdain merged commit e1816e3 into Kitware:main Jan 6, 2025
4 checks passed
@jourdain
Copy link
Collaborator

jourdain commented Jan 6, 2025

I'm not sure why a new released was not triggered.

Just some possible guess:

  1. I merged instead of rebase which changed the commit and no version change was detected
  2. The commit message was not properly formatted fix (explorer consistency): ... instead of fix(explorers): ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants