Sort video frames by time #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable the option to tell video_input_image_list to sort the set of frames according to their timestamps. This will alter their frame numbers and may prevent some potential issues that could arise particularly with pipelines because we generally process things in temporal order and expect that to match frame order. (In particular, there are some places that we expect things to arrive in temporal order that try to append to KWIVER tracks, which will fail if the frame number order does not match the temporal order.) Note that this "depends" on Kitware/kwiver#1007, which adds the aforementioned functionality to KWIVER. Things will still run without that, but this change won't do anything.
KyleFromKitware
approved these changes
Jun 3, 2020
BetsyMcPhail
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the option to tell
video_input_image_listto sort the set of frames according to their timestamps. This will alter their frame numbers and may prevent some potential issues that could arise particularly with pipelines because we generally process things in temporal order and expect that to match frame order. (In particular, there are some places that we expect things to arrive in temporal order that try to append to KWIVERtracks, which will fail if the frame number order does not match the temporal order.)Note that this "depends" on Kitware/kwiver#1007, which adds the aforementioned functionality to KWIVER. Things will still run without that, but this change won't do anything.