Fix proxy list #24
Merged
Fix proxy list #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jo-Byr
force-pushed
the
fix-proxy-list
branch
from
e7adbbb to
9e7bd27
Compare
jourdain
approved these changes
Dec 20, 2024
|
Can you try to fix #23 too? |
bourdaisj
approved these changes
Dec 23, 2024
Prevent deletion of element of proxy list below default size
finetjul
reviewed
Jan 9, 2025
| } | ||
| this.dynamicSize = this.model.length; |
There was a problem hiding this comment.
now that you know what dynamicSize is, you might want to "document" it somewhere.
There was a problem hiding this comment.
It is simply a reactive Vue property. It is defined differently in Vue2 and Vue3 but in both cases the point is that updating it updates the component.
It is defined for multiple files, should it be ducomented in all of these places ?
There was a problem hiding this comment.
should it be ducomented in all of these places ?
not necessarily. Wherever it makes most sense, but it can simply be in the file you modified in your commit.
|
LGTM for the 3 latest commits |
|
Draft status should be removed once ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix recent bugs introduced in PR#22 (proxy-list support):