New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(RWInteractor): async requestPointerLock #3205

Draft

floryst wants to merge 1 commit into master from requestpointerlock-async

Collaborator

floryst commented Jan 16, 2025 •

edited

Loading

Context

Chrome 131+ now requests permissions for pointer lock. We need to ensure that pointer lock is achieved before continuing with interactions.

Results

support async requestPointerLock

Changes

all calls to requestPointerLock have been updated
examine whether methods calling requestPointerLock should be made async

PR and Code Checklist

semantic-release commit messages
Run npm run reformat to have correctly formatted code

Testing

This change adds or fixes unit tests
Tested environment:
- vtk.js:
- OS:
- Browser:


          fix(RWInteractor): async requestPointerLock

7240b49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet