ENH: Comment out unused variable

[jhlegarreta]

Comment out unused variable: getting the largest possible region of the superclass (ImageToImageFilter) is most likely being exercised in ITK proper.

Keep the commented code in case it is found to be useful when revisiting it in the future.

Fixes:

test/itkMorphologicalContourInterpolationTest.cxx:37:34:
 warning: unused variable 'reg' [-Wunused-variable]
   37 |   typename ImageType::RegionType reg = test->GetLargestPossibleRegion();
      |                                  ^~~

raised for example in:
https://open.cdash.org/viewBuildError.php?type=1&buildid=10154304

[jhlegarreta]

@dzenanz @blowekamp @hjmjohnson

[jhlegarreta]

I am happy to remove the entire block if we believe is better.

[blowekamp]

I am happy to remove the entire block if we believe is better.

Yes, I think this would be the better approach. We don't want to keep code history in commented out code.

[jhlegarreta]

Yes, I think this would be the better approach. We don't want to keep code history in commented out code.

Done. Force pushed.

[dzenanz]

We probably need itk-module-deps for RLEImage, like this:
https://github.com/KitwareMedical/ITKUltrasound/blob/6f6fc8f6d2fac00bbe3b505d8ba00164884891da/.github/workflows/build-test-package.yml#L9

[jhlegarreta]

Thanks @dzenanz. Added commit c094347.

[jhlegarreta]

A new RLEImage release is needed, as this fix in KitwareMedical/ITKRLEImage#67 needs to be included so that the build can succeed:
https://open.cdash.org/viewBuildError.php?buildid=10163759

@dzenanz Any chance to do that? Not sure if that involves bumping the version in pyproject.toml as well: I remember some discussion about that, but cannot find it now :-/.

[dzenanz]

A PR which changes the version number getting merged, and then creating a tag in GitHub web interface.

[dzenanz]

I think the only place where version is specified is here:
https://github.com/KitwareMedical/ITKRLEImage/blob/main/pyproject.toml#L7

[jhlegarreta]

👍 Sounds good.

[jhlegarreta]

@dzenanz The new version will need to be uploaded to PyPI as well. Thanks.

[dzenanz]

I made a tag:
https://github.com/KitwareMedical/ITKRLEImage/releases/tag/v1.0.2

When CI finishes, it should automatically publish a new version on PyPI.

[jhlegarreta]

Unless the version in pyproject.toml changes, the package information will then have the wrong version information, right?

[dzenanz]

Yes, I bumped that version, see KitwareMedical/ITKRLEImage@44c747a.

[jhlegarreta]

CI is green; no warnings in the dahsboard: https://open.cdash.org/index.php?project=Insight

Ready to be merged. Thanks for the hard work @dzenanz !