Cast rapidjson errors to int for logging.

Klebert-Engineering · Feb 22, 2024 · 3856537 · 3856537
1 parent 684fecc
commit 3856537
Show file tree

Hide file tree

Showing 9 changed files with 14 additions and 14 deletions.
diff --git a/Cesium3DTilesContent/src/B3dmToGltfConverter.cpp b/Cesium3DTilesContent/src/B3dmToGltfConverter.cpp
@@ -153,7 +153,7 @@ rapidjson::Document parseFeatureTableJsonData(
     result.errors.emplaceError(fmt::format(
         "Error when parsing feature table JSON, error code {} at byte offset "
         "{}",
-        (int)document.GetParseError(),
+        static_cast<int32_t>(document.GetParseError()),
         document.GetErrorOffset()));
     return document;
   }
@@ -213,7 +213,7 @@ void convertB3dmMetadataToGltfStructuralMetadata(
             "Error when parsing batch table JSON, error code {} at byte "
             "offset "
             "{}. Skip parsing metadata",
-            batchTableJson.GetParseError(),
+            static_cast<int32_t>(batchTableJson.GetParseError()),
             batchTableJson.GetErrorOffset()));
         return;
       }

diff --git a/Cesium3DTilesContent/src/PntsToGltfConverter.cpp b/Cesium3DTilesContent/src/PntsToGltfConverter.cpp
@@ -617,7 +617,7 @@ rapidjson::Document parseFeatureTableJson(
     parsedContent.errors.emplaceError(fmt::format(
         "Error when parsing feature table JSON, error code {} at byte offset "
         "{}",
-        document.GetParseError(),
+        static_cast<int32_t>(document.GetParseError()),
         document.GetErrorOffset()));
     return document;
   }
@@ -783,7 +783,7 @@ rapidjson::Document parseBatchTableJson(
         "Error when parsing batch table JSON, error code {} at byte "
         "offset "
         "{}. Skip parsing metadata",
-        document.GetParseError(),
+        static_cast<int32_t>(document.GetParseError()),
         document.GetErrorOffset()));
     return document;
   }

diff --git a/Cesium3DTilesContent/src/QuantizedMeshLoader.cpp b/Cesium3DTilesContent/src/QuantizedMeshLoader.cpp
@@ -1178,7 +1178,7 @@ static QuantizedMeshMetadataResult processMetadata(
   if (metadata.HasParseError()) {
     result.errors.emplaceError(fmt::format(
         "Error when parsing metadata, error code {} at byte offset {}",
-        metadata.GetParseError(),
+        static_cast<int32_t>(metadata.GetParseError()),
         metadata.GetErrorOffset()));
     return result;
   }

diff --git a/Cesium3DTilesSelection/src/CesiumIonTilesetLoader.cpp b/Cesium3DTilesSelection/src/CesiumIonTilesetLoader.cpp
@@ -58,7 +58,7 @@ std::optional<std::string> getNewAccessToken(
         pLogger,
         "Error when parsing Cesium ion response, error code {} at byte offset "
         "{}",
-        ionResponse.GetParseError(),
+        static_cast<int32_t>(ionResponse.GetParseError()),
         ionResponse.GetErrorOffset());
     return std::nullopt;
   }
@@ -244,7 +244,7 @@ mainThreadHandleEndpointResponse(
     result.errors.emplaceError(fmt::format(
         "Error when parsing Cesium ion response JSON, error code {} at byte "
         "offset {}",
-        ionResponse.GetParseError(),
+        static_cast<int32_t>(ionResponse.GetParseError()),
         ionResponse.GetErrorOffset()));
     return externals.asyncSystem.createResolvedFuture(std::move(result));
   }

diff --git a/Cesium3DTilesSelection/src/LayerJsonTerrainLoader.cpp b/Cesium3DTilesSelection/src/LayerJsonTerrainLoader.cpp
@@ -386,7 +386,7 @@ Future<LoadLayersResult> loadLayersRecursive(
                 loadLayersResult.errors.emplaceWarning(fmt::format(
                     "Error when parsing layer.json, error code {} at byte "
                     "offset {}",
-                    layerJson.GetParseError(),
+                    static_cast<int32_t>(layerJson.GetParseError()),
                     layerJson.GetErrorOffset()));
                 return asyncSystem.createResolvedFuture(
                     std::move(loadLayersResult));
@@ -490,7 +490,7 @@ Future<LoadLayersResult> loadLayerJson(
     LoadLayersResult result;
     result.errors.emplaceError(fmt::format(
         "Error when parsing layer.json, error code {} at byte offset {}",
-        layerJson.GetParseError(),
+        static_cast<int32_t>(layerJson.GetParseError()),
         layerJson.GetErrorOffset()));
     return asyncSystem.createResolvedFuture(std::move(result));
   }

diff --git a/Cesium3DTilesSelection/src/TilesetContentManager.cpp b/Cesium3DTilesSelection/src/TilesetContentManager.cpp
@@ -689,7 +689,7 @@ TilesetContentManager::TilesetContentManager(
                 result.errors.emplaceError(fmt::format(
                     "Error when parsing tileset JSON, error code {} at byte "
                     "offset {}",
-                    tilesetJson.GetParseError(),
+                    static_cast<int32_t>(tilesetJson.GetParseError()),
                     tilesetJson.GetErrorOffset()));
                 return asyncSystem.createResolvedFuture(std::move(result));
               }

diff --git a/Cesium3DTilesSelection/src/TilesetJsonLoader.cpp b/Cesium3DTilesSelection/src/TilesetJsonLoader.cpp
@@ -685,7 +685,7 @@ TileLoadResult parseExternalTilesetInWorkerThread(
     SPDLOG_LOGGER_ERROR(
         pLogger,
         "Error when parsing tileset JSON, error code {} at byte offset {}",
-        tilesetJson.GetParseError(),
+        static_cast<int32_t>(tilesetJson.GetParseError()),
         tilesetJson.GetErrorOffset());
     return TileLoadResult::createFailedResult(std::move(pCompletedRequest));
   }
@@ -782,7 +782,7 @@ TilesetJsonLoader::createLoader(
           result.errors.emplaceError(fmt::format(
               "Error when parsing tileset JSON, error code {} at byte offset "
               "{}",
-              tilesetJson.GetParseError(),
+              static_cast<int32_t>(tilesetJson.GetParseError()),
               tilesetJson.GetErrorOffset()));
           return result;
         }

diff --git a/CesiumRasterOverlays/src/BingMapsRasterOverlay.cpp b/CesiumRasterOverlays/src/BingMapsRasterOverlay.cpp
@@ -371,7 +371,7 @@ BingMapsRasterOverlay::createTileProvider(
           fmt::format(
               "Error while parsing Bing Maps imagery metadata, error code "
               "{} at byte offset {}",
-              response.GetParseError(),
+              static_cast<int32_t>(response.GetParseError()),
               response.GetErrorOffset())});
     }
 

diff --git a/CesiumRasterOverlays/src/IonRasterOverlay.cpp b/CesiumRasterOverlays/src/IonRasterOverlay.cpp
@@ -127,7 +127,7 @@ IonRasterOverlay::createTileProvider(
                   fmt::format(
                       "Error while parsing Cesium ion raster overlay response, "
                       "error code {} at byte offset {}",
-                      response.GetParseError(),
+                      static_cast<int32_t>(response.GetParseError()),
                       response.GetErrorOffset())});
             }