Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BaseObject and BaseArray classes #98

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add BaseObject and BaseArray classes #98

wants to merge 11 commits into from

Conversation

josephbirkner
Copy link
Member

... to simplify creation of typed derivatives without needing to write the simfil protocol boilerplate.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

Test Results

 1 files  ±0   1 suites  ±0   3m 12s ⏱️ +10s
36 tests ±0  36 ✅ ±0  0 💤 ±0  0 ❌ ±0 
37 runs  ±0  37 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ce417bf. ± Comparison against base commit a269453.

♻️ This comment has been updated with latest results.

@josephbirkner josephbirkner marked this pull request as ready for review October 28, 2024 12:16
@josephbirkner josephbirkner marked this pull request as draft October 30, 2024 16:33
@josephbirkner josephbirkner marked this pull request as ready for review November 4, 2024 14:16
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
103 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

Package Line Rate Branch Rate Health
include.simfil 64% 47% ➖
include.simfil.model 87% 53% ✔
src 72% 41% ➖
src.model 81% 49% ✔
Summary 74% (2162 / 2907) 44% (1819 / 4135) ➖

Minimum allowed line rate is 50%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johannes-wolf johannes-wolf Awaiting requested review from johannes-wolf

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephbirkner @Waguramu