Add /auth/token endpoint for service to exchange secret for api token #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moritzzingg-netlight
suggested changes
Mar 6, 2025
|
|
||
| if (newToken !== undefined) { | ||
| reply.headers['x-auth-token'] = newToken | ||
| } else { | ||
| request.log.error('No user found') | ||
| request.log.error('Could not create new token for user', user) |
There was a problem hiding this comment.
newToken can have the value undefined if the current token is still valid for longer than 15min, in that case it is not necessary to provide a new token. So catching the case that the token is undefined as an error is wrong here.
| } | ||
| } | ||
| ) | ||
| app.post( |
|
|
||
| interface Userinfo { | ||
| interface GithubUserinfo { |
There was a problem hiding this comment.
Not happy with this name as the user info acts both for github users and non-github clients, so keeping the more general name userinfo might be better, also that one is not perfect. But, to fully fix this we would have to separate real users and clients.
| }) | ||
|
|
||
| const token = (await response.json()).token | ||
| console.log(token) |
There was a problem hiding this comment.
can be removed before merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix client missing client authentication
API_SECRETcurrently)bot: booleanfield in User entityCloses #653